contrib/gorilla/mux: allow custom resource naming #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
suggested changes
Mar 23, 2020
There was a problem hiding this comment.
Thanks a lot for your first contribution. Would you mind please following our contribution guidelines and opening an issue to discuss the change you want to make before committing to it? It will allow us to more intimately discuss the motivations and find the best possible solution.
Please make sure you explain why you want the change and how it would benefit you.
|
Hi - sorry, I missed that part of the guidelines. I've opened an issue now (#618) and linked to it from the PR comment. |
Adds a new `WithResourceNamer` option for the Gorilla Mux router that allows customizing how resources are named based on information from the router itself and the HTTP request being named.
|
I've done some tweaks in regards to the changes you requested - let me know if you have more input and I'll happily adjust. |
gbbr
approved these changes
Mar 24, 2020
|
Thanks - happy to help! |
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
Adds a new `WithResourceNamer` that allows customizing how resources are named based on information from the router and the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows customizing the resource names reported to DataDog by specifying a
WithResourceNameroption on the Mux router. The namer function takes in the*mux.Routeritself and the*http.Requestbeing handled and should provide enough context to produce a resource name for most use cases.The default namer is still the one that uses the path template on the matched route.
Closes #618